breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
force-pushed
the
breaking/MediaPlaybackRequiresUserAction
branch
3 times, most recently
from
581a1ef
to
d322947
Compare
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
=========================================
- Coverage 74.36% 74.2% -0.17%
=========================================
Files 13 13
Lines 1845 1849 +4
=========================================
Hits 1372 1372
- Misses 473 477 +4
Continue to review full report at Codecov.
|
* As the new preference key always exists in "defaults.xml", the old preference key would never be used. * Updated deprecation warning logic to include "has been" deprecated since it was completely removed. Most cases the warning would be removed as well but the previous releases never properly warn the user. Warning will remain for next major only as a migration step for users.
erisu
force-pushed
the
breaking/MediaPlaybackRequiresUserAction
branch
from
d322947
to
cb8f965
Compare
knight9999
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
MediaPlaybackRequiresUserActionwas replaced withMediaTypesRequiringUserActionForPlaybackin a previous PR. Since theMediaTypesRequiringUserActionForPlaybackdefaults will always exist indefaults.xml,MediaPlaybackRequiresUserActionwill never be read. The old preference logic should actually be removed.Additionally, the old preference
MediaPlaybackRequiresUserActionacceptedbooleanvalues but the newMediaTypesRequiringUserActionForPlaybackpreference does not accept boolean. This needs to be corrected to accept proper value types.Description
This PR removes all of
MediaPlaybackRequiresUserActionlogic except for the deprecated warning. The warning is used to provide users a migration step. It will be removed in a later release.This PR has also updated the native code to pass in the correct variable types for the new
MediaTypesRequiringUserActionForPlaybackpreference option.Example valid preference option with proper values are:
Testing
npm tcordova platform addcordova build iosChecklist